On 9/27/25 03:08, Suren Baghdasaryan wrote: > On Wed, Sep 10, 2025 at 1:01 AM Vlastimil Babka <[email protected]> wrote: >> >> From: "Liam R. Howlett" <[email protected]> >> >> Use prefilled sheaves instead of bulk allocations. This should speed up >> the allocations and the return path of unused allocations. >> >> Remove the push and pop of nodes from the maple state as this is now >> handled by the slab layer with sheaves. >> >> Testing has been removed as necessary since the features of the tree >> have been reduced. >> >> Signed-off-by: Liam R. Howlett <[email protected]> >> Signed-off-by: Vlastimil Babka <[email protected]> > > Couple nits but otherwise looks great! > > Reviewed-by: Suren Baghdasaryan <[email protected]> > >> --- >> include/linux/maple_tree.h | 6 +- >> lib/maple_tree.c | 326 ++++++--------------------- >> tools/testing/radix-tree/maple.c | 461 >> ++------------------------------------- >> tools/testing/shared/linux.c | 5 +- >> 4 files changed, 88 insertions(+), 710 deletions(-) >> >> diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h >> index >> bafe143b1f783202e27b32567fffee4149e8e266..166fd67e00d882b1e6de1f80c1b590bba7497cd3 >> 100644 >> --- a/include/linux/maple_tree.h >> +++ b/include/linux/maple_tree.h >> @@ -442,7 +442,8 @@ struct ma_state { >> struct maple_enode *node; /* The node containing this entry */ >> unsigned long min; /* The minimum index of this node - >> implied pivot min */ >> unsigned long max; /* The maximum index of this node - >> implied pivot max */ >> - struct maple_alloc *alloc; /* Allocated nodes for this >> operation */ >> + struct slab_sheaf *sheaf; /* Allocated nodes for this >> operation */ >> + unsigned long node_request; > > No comment for this poor fella?
adding: /* The number of nodes to allocate for this operation */
