On 9/29/2025 5:39 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 29, 2025 at 02:06:11PM +0800, Jingyi Wang wrote:
>>
>>
>> On 9/25/2025 10:19 AM, Dmitry Baryshkov wrote:
>>> On Wed, Sep 24, 2025 at 04:37:22PM -0700, Jingyi Wang wrote:
>>>> Document compatible for Qualcomm Kaanapali SoC ADSP PAS which looks fully
>>>> compatible with SM8750, which can fallback to SM8550 except for one more
>>>> interrupt ("shutdown-ack").
>>>>
>>>> Signed-off-by: Jingyi Wang <[email protected]>
>>>> ---
>>>> Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 6
>>>> +++++-
>>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>>>> b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>>>> index 2dd479cf4821..be9e2a0bc060 100644
>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>>>> @@ -28,7 +28,9 @@ properties:
>>>> - qcom,x1e80100-adsp-pas
>>>> - qcom,x1e80100-cdsp-pas
>>>> - items:
>>>> - - const: qcom,sm8750-adsp-pas
>>>> + - enum:
>>>> + - qcom,kaanapali-adsp-pas
>>>> + - qcom,sm8750-adsp-pas
>>>> - const: qcom,sm8550-adsp-pas
>>>> - items:
>>>> - const: qcom,sm8750-cdsp-pas
>>>> @@ -95,6 +97,7 @@ allOf:
>>>> compatible:
>>>> contains:
>>>> enum:
>>>> + - qcom,kaanapali-adsp-pas
>>>
>>> This one and the next entry are redundant. Do you see why?
>>>
>>
>> This one describe the interrupt:
>>
>> - if:
>> properties:
>> compatible:
>> contains:
>
>> enum:
>> - qcom,kaanapali-adsp-pas
>> - qcom,sm8750-adsp-pas
>
> It's still redundant. Don't you see it?
>
sorry I didn't get your point here, could you explain more?
>> then:
>> properties:
>> interrupts:
>> maxItems: 6
>> interrupt-names:
>> maxItems: 6
>> memory-region:
>> maxItems: 2
>>
>>
>>>> - qcom,sm8750-adsp-pas
>>>> then:
>>>> properties:
>>>> @@ -185,6 +188,7 @@ allOf:
>>>> compatible:
>>>> contains:
>>>> enum:
>>>> + - qcom,kaanapali-adsp-pas
>>
>> This one describe the power domain
>>
>> - if:
>> properties:
>> compatible:
>> contains:
>> enum:
>> - qcom,kaanapali-adsp-pas
>> - qcom,sm8550-adsp-pas
>> - qcom,sm8650-adsp-pas
>> - qcom,sm8750-adsp-pas
>> - qcom,x1e80100-adsp-pas
>
> Likewise
>
indeed, here is redundant as "qcom,sm8550-adsp-pas" is added in
the dts. I will remove this.
Thanks,
Jingyi
>> then:
>> properties:
>> power-domains:
>> items:
>> - description: LCX power domain
>> - description: LMX power domain
>> power-domain-names:
>> items:
>> - const: lcx
>> - const: lmx
>>
>>
>>>> - qcom,sm8550-adsp-pas
>>>> - qcom,sm8650-adsp-pas
>>>> - qcom,sm8750-adsp-pas
>>>>
>>>> --
>>>> 2.25.1
>>>>
>>>
>>
>> Thanks,
>> Jingyi
>
