On Sun, Oct 12, 2025 at 04:57:41PM -0700, Nicolin Chen wrote: > The last gdev is the device that failed the __iommu_device_set_domain(). > So, it doesn't need to be reverted, given it's attached to group->domain > already. > > This is not a problem currently, since it's a simply re-attach. However, > the core will need to pass in the old domain to __iommu_device_set_domain > so the old domain pointers would be inconsistent between a failed device > and all its prior succeeded devices, as all the prior devices need to be > reverted. > > Avoid the re-attach for the last gdev, by breaking before the revert. > > Signed-off-by: Nicolin Chen <[email protected]> > --- > drivers/iommu/iommu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Jason Gunthorpe <[email protected]> Jason

