On 1/2/26 2:00 PM, Bryan O'Donoghue wrote: > On 02/01/2026 12:00, Konrad Dybcio wrote: >> Now I don't like that this driver is going >> >> val |= BIT(i); >> writel(val, foo); >> // val is "altered" but not really >> val |= readl(foo); >> >> I didn't notice we were just doing a readback for the sake of a readback >> in the last revision. MDM9607 should most definitely have it too.. >> Perhaps I should have just read the comment > > Yeah this just looks dodgy and inconsistent in this code. > > And anyway, why OR those bits in...
Changing |= to just = would make it easier to follow indeed Konrad
