On Mon, Dec 29, 2025 at 04:26:59PM +0100, Krzysztof Kozlowski wrote:
> One SDM845 board uses cx-supply, which is not allowed by the bindings,
> as reported by dtbs_check:
>
> sdm845-samsung-starqltechn.dtb: remoteproc@5c00000 (qcom,sdm845-slpi-pas):
> Unevaluated properties are not allowed ('cx-supply' was unexpected)
>
> The SDM845 SLPI binding already allows lcx and lmx domains, thus the
> cx-supply seems like a fake name for something else, e.g. some
> enable pin.
We've seen a few other cases where specific rails are powered by
external LDOs, instead of the rails represented as RPMh power-domains,
but I can't see that this would apply for CX.
> The qcom_q6v5_pas.c driver parses cx-supply, so it is an
> established ABI, therefore document it for this device only.
This part of the implementation is a remnant from times before we had
decided to represent the corner(level)-based power rails as
power-domains (and iirc some older platforms still need/expect this).
Regards,
Bjorn
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 137f95028313..16a245fe2738 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -32,6 +32,8 @@ properties:
> reg:
> maxItems: 1
>
> + cx-supply: true
> +
> px-supply:
> description: Phandle to the PX regulator
>
> @@ -159,6 +161,9 @@ allOf:
> items:
> - const: lcx
> - const: lmx
> + else:
> + properties:
> + cx-supply: false
>
> - if:
> properties:
> --
> 2.51.0
>
