On 17/01/2026 22:49, Bryan O'Donoghue wrote:
On 17/01/2026 15:36, David Heidelberg via B4 Relay wrote:
From: Casey Connolly <[email protected]>
Add a PHY configuration sequence for the sdm845 which uses a Qualcomm
Gen 2 version 1.1 CSI-2 PHY.
The PHY can be configured as two phase or three phase in C-PHY or D-PHY
mode. This configuration supports three-phase C-PHY mode.
Signed-off-by: Casey Connolly <[email protected]>
Reviewed-by: Vladimir Zapolskiy <[email protected]>
Reviewed-by: Bryan O'Donoghue <[email protected]>
Co-developed-by: David Heidelberg <[email protected]>
Signed-off-by: David Heidelberg <[email protected]>
---
.../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 70 ++++++++++++
+++++++++-
1 file changed, 69 insertions(+), 1 deletion(-)
[...]
@@ -1050,7 +1114,11 @@ static int csiphy_lanes_enable(struct
csiphy_device *csiphy,
switch (csiphy->camss->res->version) {
case CAMSS_845:
- { /* V4L2_MBUS_CSI2_DPHY */
+ if (c->phy_cfg == V4L2_MBUS_CSI2_CPHY) {
+ regs->lane_regs = &lane_regs_sdm845_3ph[0];
+ regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845_3ph);
+
+ } else { /* V4L2_MBUS_CSI2_DPHY */
This is inconsistent commenting Ted and I'd reckon something
checkpatch.pl spits back at you.
If checkpatch.pl doesn't complain about it, I think it probably should.
Please standardise the location of the comment and have one for the CPHY
and one for the DPHY configs.
Then I can rather replace the else with elseif (== DPHY) and make the
comment irrelevant. What is your recommendation?
David>
regs->lane_regs = &lane_regs_sdm845[0];
regs->lane_array_size = ARRAY_SIZE(lane_regs_sdm845);
}
Once implemented.
Reviewed-by: Bryan O'Donoghue <[email protected]>
---
bod
--
David Heidelberg
