On Wed Jan 28, 2026 at 2:38 PM CET, Rob Herring (Arm) wrote:
>
> On Wed, 28 Jan 2026 13:26:49 +0100, Luca Weiss wrote:
>> Add bindings for pin controller in Low Power Audio SubSystem (LPASS).
>>
>> Signed-off-by: Luca Weiss <[email protected]>
>> ---
>> .../pinctrl/qcom,sm6350-lpass-lpi-pinctrl.yaml | 124
>> +++++++++++++++++++++
>> 1 file changed, 124 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lpi-pinctrl.example.dtb:
> pinctrl@33c0000 (qcom,sm6350-lpass-lpi-pinctrl): Unevaluated properties are
> not allowed ('i2s1-active-pins' was unexpected)
> from schema $id:
> http://devicetree.org/schemas/pinctrl/qcom,sm6350-lpass-lpi-pinctrl.yaml
I fixed the dtsi addition but forgot about the schema.
Will include this diff in v2:
diff --git
a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lpi-pinctrl.yaml
b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lpi-pinctrl.yaml
index 2fa2484e7bc7..4903b2d37d89 100644
---
a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lpi-pinctrl.yaml
+++
b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-lpass-lpi-pinctrl.yaml
@@ -96,8 +96,8 @@ examples:
clock-names = "core",
"audio";
- i2s1_active: i2s1-active-pins {
- clk {
+ i2s1_active: i2s1-active-state {
+ clk-pins {
pins = "gpio6";
function = "i2s1_clk";
drive-strength = <8>;
@@ -105,7 +105,7 @@ examples:
output-high;
};
- ws {
+ ws-pins {
pins = "gpio7";
function = "i2s1_ws";
drive-strength = <8>;
@@ -113,7 +113,7 @@ examples:
output-high;
};
- data {
+ data-pins {
pins = "gpio8", "gpio9";
function = "i2s1_data";
drive-strength = <8>;
Regards
Luca
