On 26/02/16 12:18, Konrad Dybcio wrote:
> Hello, just a couple comments below
Thanks for the feedback!
> > +// make sure gcc is probed with display disabled.
> > +&gcc {
> > + clocks = <&xo_board>, <&sleep_clk>, <0>, <0>, <0>, <0>, <0>;
> > +};
>
> Do things break if you remove this line?
I tested it without and it still works. I just included it because
it was on the pmos msm8916 mainlining wiki page.
> > +
> > +&gpu {
> > + status = "okay";
> > +};
> > +
> > +&mdss {
> > + status = "okay";
> > +};
> > +
> > +&mpss_mem {
> > + reg = <0x0 0x86800000 0x0 0x5600000>;
> > +};
> > +
> > +&pm8916_l6 {
> > + regulator-always-on;
>
> Is there a reason for this?
I removed the always-on property, it was for testing purposes.
mpss_mem is needed for audio to work.
I removed mdss since it is only needed for the panel.
Should the gpu only be enabled when the panel is added?
Also should I wait some time for additional comments or immediatly
send a new version when all remarks are addressed?
Paul
