Re: [PATCH v3 2/4] pid: check init is created first after idr alloc

[Pavel Tikhomirov]

On 2/25/26 14:06, Oleg Nesterov wrote:
> On 02/25, Pavel Tikhomirov wrote:
>>
>> On 2/25/26 10:06, Oleg Nesterov wrote:
>>> On 02/24, Andrei Vagin wrote:
>>>>
>>>> I don't think this is an issue right now, as we only allow one attempt
>>>> to create the init. If that first attempt fails, free_pid will disable
>>>> further PID allocations in the target namespace.
>>>
>>> Thanks, you are right!
>>
>> I guess it means that we should change the commit message a bit, e.g.: 
>> replace
>> "Effectively leading ..." to "Though thanks to PIDNS_ADDING logic, free_pid()
>> disables further pid allocation in this case and it does not lead to any real
>> problem.".
> 
> Agreed,
> 
>> Please advise if I should resend the whole series (v4) for that?
> 
> This is a question for Andrew ;)
> 
> I guess you can just send a single [PATCH v4 2/4] in reply to v3, but it won't
> hurt if you resend the whole series.

Ok, I did the v4 series resend. And also included your review tags inline.

> 
> Oleg.
> 

-- 
Best regards, Pavel Tikhomirov
Senior Software Developer, Virtuozzo.