Re: [PATCH bpf-next v5 1/2] bpf: Add wakeup_source iterator

[Samuel Wu]

On Wed, Feb 25, 2026 at 2:03 PM <bot+bpf...@kernel.org> wrote:
>
> > diff --git a/kernel/bpf/wakeup_source_iter.c 
> > b/kernel/bpf/wakeup_source_iter.c
> > --- /dev/null
> > +++ b/kernel/bpf/wakeup_source_iter.c
>
> [ ... ]
>
> > +static void wakeup_source_iter_seq_stop(struct seq_file *seq, void *v)
> > +{
> > +     int *srcuidx = seq->private;
> > +
> > +     if (*srcuidx >= 0)
> > +             wakeup_sources_read_unlock(*srcuidx);
> > +     *srcuidx = -1;
> > +}
>
> Should wakeup_source_iter_seq_stop() call
> __wakeup_source_seq_show(seq, v, true) when v is NULL, before
> releasing the SRCU lock?

This is the same response as in v3 and v4, but I don't think it's
necessary here since we don't need any additional output after
finalization, such as printing a footer.

I understand it that bpf-next is now open for processing since the
merge window is closed, so unless a human reviewer has a different
opinion on this I'll ignore this AI feedback for now.

> [ ... ]