On Fri, Mar 06, 2026 at 02:48:37PM +0100, Luca Weiss wrote: > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,milos-gxclkctl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Graphics power domain Controller on Milos
Power Domain > + > +maintainers: > + - Luca Weiss <[email protected]> > + > +description: | > + Qualcomm GX(graphics) is a clock controller which has PLLs, clocks and > + Power domains (GDSC). This module provides the power domains control > + of gxclkctl on Qualcomm SoCs which helps the recovery of Graphics > subsystem. > + > + See also: > + include/dt-bindings/clock/qcom,kaanapali-gxclkctl.h Milos > + > +properties: > + compatible: > + enum: > + - qcom,milos-gxclkctl > + > + power-domains: > + description: > + Power domains required for the clock controller to operate > + items: > + - description: GFX power domain > + - description: GPUCC(CX) power domain > + > + '#power-domain-cells': > + const: 1 > + > + reg: > + maxItems: 1 reg should be the second property, like you have it in "required" part. I guess you copied it from kaanapali-gxclkctl.yaml, so lesson - qcom bindings have acceptable quality, but not good enough to take as correct starting point. Best regards, Krzysztof
