Re: [PATCH net-next v3 2/3] bnxt_en: Resize RSS contexts on channel count change

[Michael Chan]

On Sun, Mar 8, 2026 at 6:12 AM Björn Töpel <bj...@kernel.org> wrote:
>
> bnxt_set_channels() rejects channel changes that alter the RSS table
> size when IFF_RXFH_CONFIGURED is set, because non-default context
> sizes were locked at creation.
>
> Replace the rejection with the new resize helpers. All validation runs
> before the device is closed; actual resize is deferred until after
> bnxt_close_nic():
>
>  1. ethtool_rxfh_can_resize() checks context 0.
>  2. ethtool_rxfh_ctxs_can_resize() validates all non-default contexts.
>  3. After bnxt_close_nic(), ethtool_rxfh_resize() applies context 0
>     changes, and ethtool_rxfh_ctxs_resize() resizes non-default
>     contexts.
>
> RSS table size only changes on P5 chips with older firmware; newer
> firmware always uses the largest table size.
>
> When context 0 uses defaults (!IFF_RXFH_CONFIGURED), steps 1 and 3 are
> skipped; the driver regenerates the table via
> bnxt_set_dflt_rss_indir_tbl().
>
> Tested-by: Pavan Chebbi <pavan.che...@broadcom.com>
> Signed-off-by: Björn Töpel <bj...@kernel.org>

Thanks.
Reviewed-by: Michael Chan <michael.c...@broadcom.com>

smime.p7s
Description: S/MIME Cryptographic Signature