On Tue, Mar 10, 2026 at 12:03:30AM +0100, Daniel Lezcano wrote: > The QMI framework proposes a set of services which are defined by an > integer identifier. The different QMI client lookup for the services > via this identifier. Moreover, the function qmi_add_lookup() and > qmi_add_server() must match the service ID but the code in different > places set the same value but with a different macro name. These > macros are spreaded across the different subsystems implementing the > protocols associated with a service. It would make more sense to > define them in the QMI header for the sake of consistency and clarity. > > This change use an unified naming for the services and enumerate the
Nit: see Documentation/process/submitting-patches.rst, "This patch" Other than that, Reviewed-by: Dmitry Baryshkov <[email protected]> > ones implemented in the Linux kernel. More services can come later and > put the service ID in this same header. > > Signed-off-by: Daniel Lezcano <[email protected]> > --- > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > -- With best wishes Dmitry
