The different subsystems implementing the QMI service protocol are using their own definition of the service id. It is not a problem but it results on having those duplicated with different names but the same value and without consistency in their name.
It makes more sense to unify their names and move the definitions in the QMI header file providing a consistent way to represent the supported protocols. Consequently the different drivers will use them instead of their own definition of the service id. Cc: Alex Elder <[email protected]> Cc: Andrew Lunn <[email protected]> Cc: "David S. Miller" <[email protected]> Cc: Eric Dumazet <[email protected]> Cc: Jakub Kicinski <[email protected]> Cc: Paolo Abeni <[email protected]> Cc: Jeff Johnson <[email protected]> Cc: Bjorn Andersson <[email protected]> Cc: Mathieu Poirier <[email protected]> Cc: Srinivas Kandagatla <[email protected]> Cc: Konrad Dybcio <[email protected]> Cc: Jaroslav Kysela <[email protected]> Cc: Takashi Iwai <[email protected]> Cc: Kees Cook <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Mark Brown <[email protected]> Cc: Wesley Cheng <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] --- Daniel Lezcano (8): soc: qcom: qmi: Enumerate the service IDs of QMI net: ipa: Use the unified QMI service ID instead of defining it locally net: drivers: wireless: ath: Use the unified QMI service ID instead of defining it locally remoteproc: qcom: Use the unified QMI service ID instead of defining it locally slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of defining it locally soc: qcom: pdr: Use the unified QMI service ID instead of defining it locally ALSA: usb-audio: qcom: Use the unified QMI service ID instead of defining it locally samples: qmi: Use the unified QMI service ID instead of defining it locally drivers/net/ipa/ipa_qmi.c | 6 ++---- drivers/net/wireless/ath/ath10k/qmi.c | 2 +- drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - drivers/net/wireless/ath/ath11k/qmi.c | 2 +- drivers/net/wireless/ath/ath11k/qmi.h | 1 - drivers/net/wireless/ath/ath12k/qmi.c | 2 +- drivers/net/wireless/ath/ath12k/qmi.h | 1 - drivers/remoteproc/qcom_sysmon.c | 2 +- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- drivers/soc/qcom/pdr_interface.c | 4 ++-- drivers/soc/qcom/pdr_internal.h | 3 --- drivers/soc/qcom/qcom_pd_mapper.c | 2 +- include/linux/soc/qcom/qmi.h | 12 ++++++++++++ samples/qmi/qmi_sample_client.c | 2 +- sound/usb/qcom/qc_audio_offload.c | 2 +- sound/usb/qcom/usb_audio_qmi_v01.h | 1 - 16 files changed, 25 insertions(+), 23 deletions(-) -- 2.43.0
