On 13/03/2026 13:06, Konrad Dybcio wrote:
On 3/12/26 12:49 AM, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>
This regulator provides for the display subsystem, thus must be on.
Fixes: 77809cf74a8c ("arm64: dts: qcom: Add support for Xiaomi Poco F1
(Beryllium)")
Signed-off-by: David Heidelberg <[email protected]>
---
regulator-boot-on:
description: bootloader/firmware enabled regulator.
It's expected that this regulator was left on by the bootloader.
If the bootloader didn't leave it on then OS should turn it on
at boot but shouldn't prevent it from being turned off later.
This property is intended to only be used for regulators where
software cannot read the state of the regulator.
While I believe what you're doing is okay, the commit message could
be interpreted in two ways:
1. The regulator must be on, since it provides the display subsystem
[and therefore the bootloader had turned it on before Linux booted]
2. The display subsystem requires that this regulator is on, so for that
subsystem to function, we must ensure that it's enabled [by Linux]
I'm almost certain you meant 1., but please make that explicit
Yes, I meant 1. (I'm aware of the documentation here).
David
Konrad
--
David Heidelberg
