On Thu, 19 Mar 2026, Marcos Paulo de Souza wrote:
> On Thu, 2026-03-19 at 14:03 +0100, Miroslav Benes wrote:
> > A nit but I think that "test-kprobe: " is unnecessary noise in the
> > subject
> > and can be dropped. It applies to all patches in the series.
>
> Ok, I'll drop it in the v2.
>
> >
> > On Fri, 13 Mar 2026, Marcos Paulo de Souza wrote:
> >
> > > Older kernels don't support true/false for boolean module
> > > parameters
> > > because they lack commit 0d6ea3ac94ca
> > > ("lib/kstrtox.c: add "false"/"true" support to kstrtobool()").
> > > Replace
> > > true/false by 1/0 so the test module can be loaded on older
> > > kernels.
> > >
> > > No functional changes.
> >
> > We also define a bool module parameter in
> > test_modules/test_klp_callbacks_busy.c. Does it have a similar
> > problem?
>
> No, because n/N was accepted as false already on 4.12 (SLE12-SP5). I'm
> not sure about older versions tough.
strtobool() (predecessor of kstrtobool()) has it from the beginning and
that is ~2010 which predates the kernel live patching itself so I think we
are good.
Miroslav
