On 20/03/2026 23:32, cristian_ci wrote: > On Thursday, March 19th, 2026 at 10:09, Krzysztof Kozlowski <[email protected]> > wrote: > >> On Wed, Mar 18, 2026 at 11:28:09PM +0100, Cristian Cozzolino wrote: >>> + avdd-supply: >>> + description: positive boost supply regulator >>> + >>> + avee-supply: >>> + description: negative boost supply regulator >>> + >>> + vci-supply: >>> + description: regulator that supplies the analog voltage >>> + >>> + vddam-supply: >>> + description: power supply for MIPI interface >>> + >>> + vddi-supply: >>> + description: regulator that supplies the I/O voltage >>> + >>> + port: true >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - reset-gpios >>> + - avdd-supply >>> + - avee-supply >>> + - vci-supply >> >> Only VDDI is required according to datasheet (see page 11 and page 16). > > Just to be sure, are you mentioning the part saying there are multiple > power modes (2-1PWR, 2-2PWR, 3éWR and 4PWR) related to NT35532? > >> Others are needed only in specific configurations, which I would ignore >> for the simplicity of the binding. Drop these three. >> >> Previous discussion point was about this - write bindings based on >> datasheet, since it is available. > > I've removed avdd, avee and vci supplies from 'required' properties > and I've also tested the new bindings (just for completeness). Now, > I'm going to reintroduce again the issue already raised previously > (for which I received no replies in v1): should I submit a v3 > series including my new changes or I've to stick with v2 here, in > order to address review concerns about binding, first? >
I don't understand the question. This is v2, right? So I asked to make changes to it, thus you should submit v3 after receiving some more review for example. Best regards, Krzysztof
