Re: [PATCH net-next v2 03/12] ethtool: Add loopback netlink UAPI definitions

[Maxime Chevallier]

On 26/03/2026 23:23, Jakub Kicinski wrote:
> On Wed, 25 Mar 2026 15:50:10 +0100 Björn Töpel wrote:
>> +      -
>> +        name: depth
>> +        type: u8
>> +        doc: |
>> +          Ordering index within a component instance. When a component
>> +          has multiple loopback points of the same type (e.g. two PCS
>> +          blocks inside a rate-adaptation PHY), depth distinguishes
>> +          them. Lower depth values are closer to the host side, higher
>> +          values are closer to the line/media side. Defaults to 0 when
>> +          there is only one loopback point per (component, name) tuple.
>> +      -
>> +        name: supported
>> +        type: u8
>> +        enum: loopback-direction
>> +        enum-as-flags: true
>> +        doc: Bitmask of supported loopback directions
>> +      -
>> +        name: direction
>> +        type: u8
>> +        enum: loopback-direction
>> +        doc: Current loopback direction, 0 means disabled
> 
> u32, Netlink attrs are padded to 4B anyway

That's my bad, I was the one suggesting u8 :( I didn't have the padding
thing in mind at that time :/

Maxime