> > Summary: > > > > IMHO, this patch is perfectly fine as is if we accept that it will get > > eventually obsoleted by my patchset (hopefully in a year or two). > > > > On the other hand, this patch would deserve some clean up, > > (helper functions, don't die in the middle of the test) if > > you planned to work on more tests. It would help to maintain > > the tests.
> Right, I think this was a good intro patch for Pablo and that the > revised execution flow would be a great follow on series, if he is > interested. How about that? Sure, will take a stab at revising the cleanup flow. And thanks for the ideas. > > This code is repeated several times. It might be worth creating a > > helper function in tools/testing/selftests/livepatch/functions.sh. Makes sense. Will include in the follow-up. Thanks for the reviews everyone, and thanks Petr for picking it up. Pablo
signature.asc
Description: PGP signature
