On Thu, Apr 02, 2026 at 07:11:43AM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" <[email protected]> > > mfill_atomic() passes a lot of parameters down to its callees. > > Aggregate them all into mfill_state structure and pass this structure to > functions that implement various UFFDIO_ commands. > > Tracking the state in a structure will allow moving the code that retries > copying of data for UFFDIO_COPY into mfill_atomic_pte_copy() and make the > loop in mfill_atomic() identical for all UFFDIO operations on PTE-mapped > memory. > > The mfill_state definition is deliberately local to mm/userfaultfd.c, > hence shmem_mfill_atomic_pte() is not updated. > > [[email protected]: properly initialize mfill_state.len to fix > folio_add_new_anon_rmap() WARN] > Link: https://lkml.kernel.org/r/abehBY7QakYF9bK4@hyeyoo > Signed-off-by: Mike Rapoport (Microsoft) <[email protected]> > Signed-off-by: Harry Yoo <[email protected]> > Acked-by: David Hildenbrand (Arm) <[email protected]>
Looks good to me, Reviewed-by: Harry Yoo (Oracle) <[email protected]> -- Cheers, Harry / Hyeonggon
