On 15:14-20260507, Markus Schneider-Pargmann wrote:
> >
> > So we go ahead an override the definitions of ipc-firmware.dtsi for
> > wkup_r5fss0_core0 here - explaining why the build does'nt fail. I am
> > confused why the ipc firmware dtsi was'nt updated instead? is this
> > something different firmware dtsi now? if so, we should split the
> > ipc-firmware.dtsi accordingly. Commit message does'nt mention the same
> > either. This right solution is to make up our minds if ipc-firmware.dtsi
> > is meant for LPM mode support or not. if not, split the dtsi, if yes, do
> > the mods in the ipc.dtsi
> 
> We can update the firmware definitions as well. I currently only did
> this for am62a and am62p as these require the new format so IO+DDR
> works. But if you prefer I can make the changes to firmware.dtsi
> instead.

That was the entire purpose of splitting ipc-firmware.dtsi out -
if the default firmware carveouts have changed, do the change in
ipc-firmware.dtsi. That way some other firmware people will have could
potentially have their own dtsi files and handle things appropriately
there, even if they are using the same evm OR if they use the exact
ipc-firmware on different boards, that will appropriately introduce
the change there as well. BUT, do check first.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 
849D 1736 249D
https://ti.com/opensource

Reply via email to