The type of guest_memfd in structure kvm_userspace_memory_region2 is __u32, it is not correct to assign it with -1 and check whether it is smaller than 0. Here check flags with KVM_MEM_GUEST_MEMFD set.
Signed-off-by: Bibo Mao <[email protected]> --- tools/testing/selftests/kvm/lib/kvm_util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 2a76eca7029d..9d3553f7e6a5 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c @@ -817,7 +817,7 @@ static void __vm_mem_region_delete(struct kvm_vm *vm, kvm_munmap(region->mmap_alias, region->mmap_size); close(region->fd); } - if (region->region.guest_memfd >= 0) + if (region->region.flags & KVM_MEM_GUEST_MEMFD) close(region->region.guest_memfd); free(region); @@ -1101,8 +1101,6 @@ void vm_mem_add(struct kvm_vm *vm, enum vm_mem_backing_src_type src_type, region->region.guest_memfd = guest_memfd; region->region.guest_memfd_offset = guest_memfd_offset; - } else { - region->region.guest_memfd = -1; } region->unused_phy_pages = sparsebit_alloc(); base-commit: 74fe02ce122a6103f207d29fafc8b3a53de6abaf -- 2.39.3
