On Thu, 21 May 2026 16:47:58 +0530, Sarthak Sharma <[email protected]>
wrote:
Hi Sarthak,
>
> diff --git a/tools/lib/mm/file_utils.c b/tools/lib/mm/file_utils.c
> new file mode 100644
> index 000000000000..0f9322f2cf41
> --- /dev/null
> +++ b/tools/lib/mm/file_utils.c
> @@ -0,0 +1,83 @@
> [ ... skip 48 lines ... ]
> + saved_errno = errno;
> + close(fd);
> + errno = saved_errno;
> + if (numwritten < 0) {
> + fprintf(stderr, "%s write(%.*s) failed: %s\n",
> + path, (int)(buflen - 1), buf, strerror(errno));
This would break TAP formatting for selftests.
> + exit(EXIT_FAILURE);
and while EXIT_FAILURE == KSFT_FAIL I'm not sure it's robust enough.
>
> diff --git a/tools/testing/selftests/mm/hugepage_settings.c
> b/tools/testing/selftests/mm/hugepage_settings.c
> index 2eab2110ac6a..5e947abb7425 100644
> --- a/tools/testing/selftests/mm/hugepage_settings.c
> +++ b/tools/testing/selftests/mm/hugepage_settings.c
> @@ -8,8 +8,9 @@
> #include <stdlib.h>
> #include <string.h>
> #include <unistd.h>
> +#include <mm/file_utils.h>
>
> -#include "vm_util.h"
I think it would be fine to include file_utils.h in vm_utils.h and avoid
further churn.
--
Sincerely yours,
Mike.
