Hey! On Fri, 22 May 2026 at 16:05, Jakub Kicinski <[email protected]> wrote: > > On Fri, 22 May 2026 13:32:19 +0200 Björn Töpel wrote: > > drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 29 +-- > > .../net/ethernet/meta/fbnic/fbnic_debugfs.c | 5 +- > > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 168 ++++++++++++++---- > > drivers/net/ethernet/meta/fbnic/fbnic_txrx.h | 6 + > > .../selftests/drivers/net/hw/iou-zcrx.c | 28 ++- > > 5 files changed, 176 insertions(+), 60 deletions(-) > > Hm. What's merging the frags? the hw will serve them back to us in 4kB > chunks. Frankly the iou zc hurts me less that the fact that we run > out of nr_frags in GRO :(
Thanks for taking a look, Jakub! The driver relies on the generic XDP frag coalescing (xdp_buff_add_frag()). So, adjacent 4K completions are extended into the same frag. IOW, GRO should see coalesced skb frab, rather than one graf per HW BDQ frag I'll address all the other comments in the next rev! Björn
