On Fri, Feb 08, 2008 at 08:24:25PM -0800, Roland Dreier wrote: > So I was perusing the code in lib/kobject.c, and I saw this: > > void kobject_init(struct kobject *kobj, struct kobj_type *ktype) > { > // [a couple of of parameter checks...] > if (kobj->state_initialized) { > /* do not error out as sometimes we can recover */ > printk(KERN_ERR "kobject (%p): tried to init an > initialized " > "object, something is seriously wrong.\n", kobj); > dump_stack(); > } > > in other words the first thing you do is check a member of the > structure you're supposed to be initializing -- if someone just > kmalloc()s a struct kobject and passes it into this function, there's > a good chance that state_initialized won't be zero. In fact, with > slab debugging on, it's guaranteed to be poisoned with a non-zero > value. > > So are users supposed to be zeroing out struct kobjects before > initializing them?
Yes. See also the check about the non-zero reference count when initializing the kref, that too will trip. > If so, this should probably be documented. You're right. Patches gladly accepted :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/