On Mon, May 25, 2026 at 12:26:59PM +0000, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s)
> to consider:
> - [High] Returning -EINVAL from pagemap_scan_test_walk() aborts the
> scan destructively, permanently losing read results for already
> write-protected pages in preceding VMAs.
Confirmed. The non-wp-allowed branch right below already follows the
right convention -- silently skip with `return 1` so the walk continues.
Will fix in v5 the same way:
- return -EINVAL;
+ return 1;
> --
> Sashiko AI review ยท
> https://sashiko.dev/#/patchset/[email protected]?part=10
--
Kiryl Shutsemau / Kirill A. Shutemov
