On Mon, May 25, 2026 at 12:24:08PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 4 potential issue(s) > to consider: > - [Critical] The documented VMM working set tracking workflow disables > async mode AFTER performing PAGEMAP_SCAN, creating a TOCTOU data loss > race condition. > - [High] UFFDIO_SET_MODE relies solely on mmap_write_lock() to > synchronize with in-flight faults, failing to exclude or drain per-VMA > locked faults. > - [Medium] The example code uses an anonymous compound literal for the > UFFDIO_API ioctl argument, making it impossible to inspect returned > features. > - [Low] The example C code contains standard C compliance issues and > an undefined variable in the `pwrite` call.
All valid. Will address in v5. > -- > Sashiko AI review ยท > https://sashiko.dev/#/patchset/[email protected]?part=14 -- Kiryl Shutsemau / Kirill A. Shutemov
