Hi Bastien, On Thu, Jun 4, 2026 at 7:32 AM Bastien Nocera <[email protected]> wrote: > > Hello Tim, > > On Wed, 2026-06-03 at 18:41 -0600, Tim Bird wrote: > > Many bluetooth source files are missing SPDX-License-Identifier > > lines. Add appropriate IDs to these files, and remove other > > license lines from the headers. > > I think it would be useful to separate the changes in drivers/bluetooth > and the ones in {include/,}net/bluetooth. > > Why do some of the id lines use C-style comments and others C++-style > comments? (/* */ vs. //) ?
It seems to be a common practice where on *.c it uses // and on *.h /* */ is used, it is consistent across other subsystems and the BlueZ userspace tree as well. > > Leave the warranty disclaimer in files where the license ID is > > GPL-2.0 but the wording of the disclaimer is slightly different > > from that of the GPL v2 disclaimer. > > > > It is not different enough to cause licensing conflicts, but is > > kept to honor the original contributors' legal intent. > > Good job doing this, do you know if there's a plan to automate this > somehow? It would be great to be able to re-run a script on top of a > codebase to verify that no sources were missed, and that we got the > same license ID assigned for the same license verbiage in the source > headers. > > Cheers -- Luiz Augusto von Dentz
