On 16/06/26 13:52, Andy Shevchenko wrote: > On Tue, Jun 16, 2026 at 1:50 PM Rodrigo Alencar > <[email protected]> wrote: > > On 16/06/26 13:43, Andy Shevchenko wrote: > > > On Tue, Jun 16, 2026 at 09:21:17AM +0100, Rodrigo Alencar via B4 Relay > > > wrote: > > > > > > > Use guarded mutex lock to facilitate code review when adding new > > > > attributes. This will allow for early returns, avoiding error-prone > > > > locking and unlocking in error paths. This also adds missing include > > > > linux/cleanup.h. Gain-control support will allow the scale attribute > > > > to be configurable. > > > > > > What about interrupt handler? You just added yet another mutex lock/unlock > > > there. Perhaps this patch should be done before the previous one? > > > > Can't add the guard(mutex)() in the trigger handler because of the goto. > > It might need a refactoring then?
It would deviate from other examples... would either repeat the code in the end inside an if statement, or wrap most of the function implementation inside one. I suppose the first option would be better. -- Kind regards, Rodrigo Alencar
