On 2026/7/2 18:14, Quentin Monnet wrote: > 2026-07-02 14:24 UTC+0800 ~ Leon Hwang <[email protected]> >> On 2/7/26 03:32, Andrii Nakryiko wrote: [...] >> diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c >> index 6ae7262ebe0c..798a34366e08 100644 >> --- a/tools/bpf/bpftool/gen.c >> +++ b/tools/bpf/bpftool/gen.c > > [...] > >> @@ -254,7 +254,7 @@ static const struct btf_type >> *find_type_for_map(struct btf *btf, const char *map >> return NULL; >> } >> >> -static bool is_mmapable_map(const struct bpf_map *map, char *buf, >> size_t sz) >> +static bool bpf_map_is_skel_data(const struct bpf_map *map, char *buf, >> size_t sz) >> { > > > Yes, I think it addresses the issue, thanks! I'd maybe drop the > "bpf_map_" prefix in the function name ("is_skel_data_map()" instead?) > to remain closer to is_mmapable_map(), and to avoid creating confusion > with libbpf functions names, although I don't feel strongly about it.
Makes sense. Will drop the prefix. > You can add my ACK to this v9 for the bpftool patch when you repost the > series. Thanks for your review. Leon
