On 7/3/26 9:59 AM, Erikas Bitovtas wrote:
> Samsung Galaxy A52/A72 are devices released on atoll (SM7125) platform
> in 2021. Add initial device tree for SM7125 Samsung platform with
> support for:
[...]
hello, mainly just style nits
> + rmtfs_mem: memory@f4f01000 {
> + compatible = "qcom,rmtfs-mem";
> + reg = <0 0xf4f01000 0 0x200000>;
0 -> 0x0 (also in all similar cases)
[...]
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&key_vol_up_default>, <&hall_sensor_default>;
property-n
property-names
[...]
> +&apps_rsc {
> + pm6150-rpmh-regulators {
> + compatible = "qcom,pm6150-rpmh-regulators";
> + qcom,pmic-id = "a";
have vou verified your reg settings? incorrect ones may lead to
hw damage
[...]
> +&pm6150_pon {
> + /* LinuxLoader fastboot implementation has most of it's commands removed
> + * by Samsung, making it useless. So reboot to Odin download mode
> instead.
> + */
/*
* foo
*/
> + mode-bootloader = <0x15>;
> +};
> +
> +&pm6150_resin {
> + linux,code = <KEY_VOLUMEDOWN>;
> + status = "okay";
let's keep an \n before 'status'
[...]
> +&tlmm {
> + gpio-reserved-ranges = <59 4>;
Do we know what they're connected to? If so, please add a comment, like
in glymur-crd.dtsi
[...]
> +&usb_1 {
> + qcom,select-utmi-as-pipe-clk;
> + status = "okay";
> +};
> +
> +&usb_1_dwc3 {
> + dr_mode = "peripheral";
> + maximum-speed = "high-speed";
Does super-speed not work (if you also remove the qcom,select... above)?
Konrad
