Hi Pratyush & Markus, On Sat, Jul 4, 2026 at 2:59 AM Pratyush Yadav <[email protected]> wrote: > > On Fri, Jul 03 2026, Markus Elfring wrote: > > >> A NULL pointer dereference issue is noticed in riscv's > >> machine_kexec_prepare(), > >> where image->segment[i].buf might be NULL and copied unchecked. > > … > > > > Would it be helpful to append parentheses to a function name also in the > > summary phrase? > > > > Why was such a hint not be taken into account from a previous suggestion? > > Oh come on, this is a really really minor nitpick. The fact that > machine_kexec_prepare is a function is fairly obvious when reading the > patch. In fact, the first sentence of the commit message uses the > parentheses. > > So yes, it would have been nice to have them in the subject. But no, > this is not at all worth anyone's time to fix. Certainly not at all > worth a v5. > > Please, let's not nitpick our contributors into giving up. >
Thanks for the review and for pointing out the issues in my patch. I'm still new to kernel patch submission and clearly have a lot to learn. I appreciate all the feedback. Thanks again for your patience and guidance. Thanks, Tao Liu > -- > Regards, > Pratyush Yadav >
