On 31/07/2026 17:41, Konrad Dybcio wrote:
On 7/30/26 12:20 AM, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>
Main rear camera uses Dongwoon DW9714V actuator. Add regulator and
actuator node.
Signed-off-by: David Heidelberg <[email protected]>
---
[...]
+ /* SGM2036-2.8YUDH4G/TR */
+ cam_bus_2p8: regulator-cam-bus-2p8 {
+ compatible = "regulator-fixed";
+
+ regulator-name = "cam_bus_2p8";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-enable-ramp-delay = <100>;
+
+ gpio = <&tlmm 8 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ pinctrl-0 = <&cam_bus_avdd_default_state>;
+ pinctrl-1 = <&cam_bus_avdd_sleep_state>;
+ pinctrl-names = "default", "sleep";
+
+ vin-supply = <&vreg_bob>;
+
+ /*
+ * TODO: This node represent bus supply to the cam i2c module.
+ * Others DT do in similar fashion, but should be addressed
+ * by the bus-supply in the future
+ */
I can't quite parse the second sentence..
I'll rephrase, I noticed that other device-trees where there is also i2c
level-shifter also introduce always-on regulator. I let clanker check impact on
power consumption, it's likely irrelevant, but in the future would be nice to
have proper bus-supply property in use instead of always-on.
[...]
+&cci_i2c0 {
+ rear_camera_actuator: actuator@c {
+ compatible = "dongwoon,dw9714v", "dongwoon,dw9714a",
"dongwoon,dw9714";
1 a line would be neater
[...]
+ cam_bus_avdd_default_state: cam-bus-avdd-default-state {
+ pins = "gpio8";
+ function = "gpio";
+ bias-disable;
+ drive-strength = <2>;
Other nodes have drive-strength first, then bias
+ };
+
+ cam_bus_avdd_sleep_state: cam-bus-avdd-sleep-state {
+ pins = "gpio8";
+ function = "gpio";
+ bias-disable;
+ drive-strength = <2>;
+ output-low;
Drop output-low, the regulator driver will set that
Sure, all noted and next version will include these changes.>
Konrad
--
David Heidelberg
