On Mon, Aug 03, 2026 at 11:30:20PM +0530, Mukesh Ojha wrote: > SDX75, Hawi and Maili MPSS are compatible with the SM8650 MPSS as > they share the same set of interrupts, memory regions and power domains. > Rather than describing them as standalone compatibles, model them as > fallbacks to qcom,sm8650-mpss-pas. >
This will introduce a dt-validation error in arch/arm64/boot/dts/qcom/sdx75.dtsi, which you fix in patch 2. But while the binding says qcom,sdx75-mpss-pas alone isn't a valid compatible, we support that in the driver, so we're maintaining backwards compatibility with current DT - until someone cleans up the driver to match the contract defined by the binding. It might be reasonable to accept both of these hiccups, but you need to document the upside of it. But if I read this correctly, it seems I merged qcom,hawi-mpss-pas and qcom,maili-mpss-pas prematurely. Based on the commit message in [1] I thought they would fall back to sm8650, but this patch says that was wrong of me - meaning that [1] should have contained a driver change as well. I.e. you didn't test [1], right? As I said in the reply to Krzysztof, I have dropped [1] again from my queue. [1] https://lore.kernel.org/all/[email protected]/ Regards, Bjorn > Signed-off-by: Mukesh Ojha <[email protected]> > --- > .../bindings/remoteproc/qcom,sm8550-pas.yaml | 29 +++++++++---------- > 1 file changed, 14 insertions(+), 15 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml > b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml > index a062188861ff..f722c55aadf4 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml > @@ -18,9 +18,6 @@ properties: > oneOf: > - enum: > - qcom,eliza-cdsp-pas > - - qcom,hawi-mpss-pas > - - qcom,maili-mpss-pas > - - qcom,sdx75-mpss-pas > - qcom,sm8550-adsp-pas > - qcom,sm8550-cdsp-pas > - qcom,sm8550-mpss-pas > @@ -49,6 +46,12 @@ properties: > - items: > - const: qcom,sm8750-cdsp-pas > - const: qcom,sm8650-cdsp-pas > + - items: > + - enum: > + - qcom,hawi-mpss-pas > + - qcom,maili-mpss-pas > + - qcom,sdx75-mpss-pas > + - const: qcom,sm8650-mpss-pas > > reg: > maxItems: 1 > @@ -205,11 +208,9 @@ allOf: > - if: > properties: > compatible: > - enum: > - - qcom,hawi-mpss-pas > - - qcom,maili-mpss-pas > - - qcom,sdx75-mpss-pas > - - qcom,sm8650-mpss-pas > + contains: > + enum: > + - qcom,sm8650-mpss-pas > then: > properties: > interrupts: > @@ -257,13 +258,11 @@ allOf: > - if: > properties: > compatible: > - enum: > - - qcom,hawi-mpss-pas > - - qcom,maili-mpss-pas > - - qcom,sdx75-mpss-pas > - - qcom,sm8550-mpss-pas > - - qcom,sm8650-mpss-pas > - - qcom,sm8750-mpss-pas > + contains: > + enum: > + - qcom,sm8550-mpss-pas > + - qcom,sm8650-mpss-pas > + - qcom,sm8750-mpss-pas > then: > properties: > power-domains: > -- > 2.53.0 >
