Hi Song Hu!
On 8/12/26 5:38 PM, Song Hu wrote:
> mremap_test calls ksft_set_plan() without ksft_print_header(), and its
> get_mmap_min_addr() skip path uses a bare exit(KSFT_SKIP) that prints no
> TAP line, so its output is not valid KTAP. Add the header and switch the
> skip to ksft_exit_skip().
>
> Signed-off-by: Song Hu <[email protected]>
> ---
While running the test, I saw that still some diagnostic lines are being
printed without being prefixed with a #. This is because of some prints
in the code of the format:
ksft_*("...\n\t...")
which is causing the part after the \n to not be prefixed with a #. If
you are planning for a respin, maybe you can include this in the same
patch so that the whole output becomes KTAP compliant :).
Rest of your changes look good. Once Sashiko's point on this patch has
been addressed, feel free to add
Reviewed-by: Sarthak Sharma <[email protected]>
