Hi Esteban, On Mon, Aug 10, 2026 at 11:31:37PM -0400, Esteban Urrutia via B4 Relay wrote: > From: Esteban Urrutia <[email protected]> > > Add driver for the Parade PS5169, an USB Type-C redriver capable of > handling 10Gb/s USB signals and 8.1Gb/s DP signals. > > Signed-off-by: Esteban Urrutia <[email protected]> > --- > MAINTAINERS | 7 + > drivers/usb/typec/mux/Kconfig | 10 + > drivers/usb/typec/mux/Makefile | 1 + > drivers/usb/typec/mux/ps5169.c | 592 > +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 610 insertions(+)
This does not compile... > diff --git a/drivers/usb/typec/mux/ps5169.c b/drivers/usb/typec/mux/ps5169.c > new file mode 100644 > index 000000000000..5fbc452249d0 > --- /dev/null > +++ b/drivers/usb/typec/mux/ps5169.c > @@ -0,0 +1,592 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Driver for Parade PS5169 USB Type-C linear redriver > + * Registers and bits decoded from downstream drivers > + * > + * Copyright (c) 2026 Esteban Urrutia <[email protected]> > + */ > + > +#include <drm/bridge/aux-bridge.h> > + > +#include <linux/i2c.h> > +#include <linux/regmap.h> You are missing a lot of headers here. Please include everything that you are using - don't rely on nested includes. I think that's the rule nowadays. Thanks, -- heikki
