If codetag_load_module() fails, err is never set and load_module()
returns 0 after the module has been torn down.

Fixes: 044d2aee6c57 ("alloc_tag: handle module codetag load errors as module 
load failures")
Reported-by: Sashiko <[email protected]>
Cc: [email protected]
Signed-off-by: Hao Ge <[email protected]>
---
 kernel/module/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/module/main.c b/kernel/module/main.c
index 46dd8d25a605..afb810f0154c 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -3568,7 +3568,8 @@ static int load_module(struct load_info *info, const char 
__user *uargs,
                        goto sysfs_cleanup;
        }
 
-       if (codetag_load_module(mod))
+       err = codetag_load_module(mod);
+       if (err)
                goto sysfs_cleanup;
 
        /* Get rid of temporary copy. */
-- 
2.25.1


Reply via email to