On Wed, Aug 19, 2026 at 04:15:04PM +0200, David Hildenbrand (Arm) wrote:
> On 8/19/26 09:47, Hemanth Selam wrote:
> > pkey-helpers.h defines PKEY_UNRESTRICTED itself when the macro is not
> > already known, a stopgap from when the generic definition was still
> > under review. It has been merged since, commit 6d61527d931b ("mm/pkey:
> > Add PKEY_UNRESTRICTED macro"), so the guard is never taken and the FIXME
> > can be honoured.
> >
> > The definition comes from tools/include/uapi/asm-generic/mman-common.h
> > via TOOLS_INCLUDES, which commit e076eaca5906 ("selftests: break the
> > dependency upon local header files") added so that the mm selftests
> > build without "make headers". It is reached through the
> > <asm-generic/mman.h> that the system <asm/mman.h> includes. Building
> > the pkey tests with KHDR_INCLUDES pointing at an empty directory
> > confirms that; emptying TOOLS_INCLUDES as well is what makes the macro
> > go missing.
> >
> > No functional change intended.
> >
> > Signed-off-by: Hemanth Selam <[email protected]>
Since you said load-bearing in the last email - I do have to ask if AI was
involved with this.
If so please adhere to kernel guidelines:
https://docs.kernel.org/process/coding-assistants.html
https://docs.kernel.org/process/generated-content.html
I.e. add an Assisted-by tag.
Anyway given your explanation in the other sub-thread seems ok so:
Acked-by: Lorenzo Stoakes (ARM) <[email protected]>
>
> Hi,
>
> please prefer not sending new revisions in reply to old revisions the next
> time.
Yup. Please send respins as an entirely separate main not in-reply to
anything, thanks!
Also add a revision history under the --- with links to prior revisions,
and if >1 patch send a cover letter that has the revisions and all patch
emails are in-reply-to.
>
> [...]
>
> > tools/testing/selftests/mm/pkey-helpers.h | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/tools/testing/selftests/mm/pkey-helpers.h
> > b/tools/testing/selftests/mm/pkey-helpers.h
> > index 2c377f4e9df1..626c2e1655dc 100644
> > --- a/tools/testing/selftests/mm/pkey-helpers.h
> > +++ b/tools/testing/selftests/mm/pkey-helpers.h
> > @@ -112,13 +112,6 @@ void record_pkey_malloc(void *ptr, long size, int
> > prot);
> > #define PKEY_MASK (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE)
> > #endif
> >
> > -/*
> > - * FIXME: Remove once the generic PKEY_UNRESTRICTED definition is merged.
> > - */
> > -#ifndef PKEY_UNRESTRICTED
> > -#define PKEY_UNRESTRICTED 0x0
> > -#endif
> > -
> > #ifndef set_pkey_bits
> > static inline u64 set_pkey_bits(u64 reg, int pkey, u64 flags)
> > {
>
> Hoping this indeed compiles ;)
>
> Acked-by: David Hildenbrand (Arm) <[email protected]>
>
> --
> Cheers,
>
> David
--
Cheers, Lorenzo
