Le 01/09/2026 à 17:50, Thomas Weißschuh a écrit :
No caller tests the return value of this function.
The integer return type is still a remnant from when the function
was executed as initcall. This usage however was removed in
commit 8c0d884986ba ("init: main: add KUnit to kernel init")
Signed-off-by: Thomas Weißschuh <[email protected]>
---
Nice catch, thanks.
Reviewed-by: David Gow <[email protected]>
Cheers,
-- David
include/kunit/test.h | 5 ++---
lib/kunit/executor.c | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/include/kunit/test.h b/include/kunit/test.h
index da5312e0dfa5..31d549578f8e 100644
--- a/include/kunit/test.h
+++ b/include/kunit/test.h
@@ -400,11 +400,10 @@ struct kunit_suite_set kunit_merge_suite_sets(struct
kunit_suite_set init_suite_
const void *kunit_array_gen_params(struct kunit *test, const void *prev, char
*desc);
#if IS_BUILTIN(CONFIG_KUNIT)
-int kunit_run_all_tests(void);
+void kunit_run_all_tests(void);
#else
-static inline int kunit_run_all_tests(void)
+static inline void kunit_run_all_tests(void)
{
- return 0;
}
#endif /* IS_BUILTIN(CONFIG_KUNIT) */
diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
index b0f8a41d61d3..c798a02470d8 100644
--- a/lib/kunit/executor.c
+++ b/lib/kunit/executor.c
@@ -371,7 +371,7 @@ static void kunit_handle_shutdown(void)
}
-int kunit_run_all_tests(void)
+void kunit_run_all_tests(void)
{
struct kunit_suite_set suite_set = {NULL, NULL};
struct kunit_suite_set filtered_suite_set = {NULL, NULL};
@@ -382,7 +382,7 @@ int kunit_run_all_tests(void)
__kunit_suites_start, __kunit_suites_end,
};
size_t init_num_suites = init_suite_set.end - init_suite_set.start;
- int err = 0;
+ int err;
if (init_num_suites > 0) {
suite_set = kunit_merge_suite_sets(init_suite_set,
normal_suite_set);
@@ -432,7 +432,6 @@ int kunit_run_all_tests(void)
out:
kunit_handle_shutdown();
- return err;
}
#if IS_BUILTIN(CONFIG_KUNIT_TEST)
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260109-kunit-void-b2f71f7e980c
Best regards,
--
Thomas Weißschuh <[email protected]>
