On Sat, 12 Sep 2026 12:18:06 -0700 SJ Park <[email protected]> wrote:
> Add test cases for testing the validation of damos filter arguments in
> commit time.
>
> Signed-off-by: SJ Park <[email protected]>
> ---
> mm/damon/tests/core-kunit.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index c9941f3bfb42b..5da84caf4124d 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
> @@ -1195,6 +1195,13 @@ static void damos_test_commit_filter(struct kunit
> *test)
> .allow = false,
> .sz_range = {.min = 234, .max = 345},
> }, false);
> + damos_test_commit_filter_for(test, &dst,
> + &(struct damos_filter){
> + .type = DAMOS_FILTER_TYPE_HUGEPAGE_SIZE,
> + .matching = false,
> + .allow = false,
> + .sz_range = {.min = 456, .max = 123},
> + }, true);
> damos_test_commit_filter_for(test, &dst,
> &(struct damos_filter){
> .type = DAMOS_FILTER_TYPE_UNMAPPED,
> @@ -1208,6 +1215,13 @@ static void damos_test_commit_filter(struct kunit
> *test)
> .allow = false,
> .addr_range = {.start = 456, .end = 567},
> }, false);
> + damos_test_commit_filter_for(test, &dst,
> + &(struct damos_filter){
> + .type = DAMOS_FILTER_TYPE_ADDR,
> + .matching = false,
> + .allow = false,
> + .addr_range = {.start = 567, .end = 456},
> + }, true);
Could we also test an invalid PROBE_HITS_WSUM range here?
Patch 4 adds the same max < min validation for
DAMOS_FILTER_TYPE_PROBE_HITS_WSUM, but this test only covers
ADDR and HUGEPAGE_SIZE.
Thanks,
Kunwu
> damos_test_commit_filter_for(test, &dst,
> &(struct damos_filter){
> .type = DAMOS_FILTER_TYPE_TARGET,
> --
> 2.47.3
>
Sent using hkml (https://github.com/sjp38/hackermail)
