On 9/23/26 3:58 PM, Jerome Brunet wrote:
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index f9592fd9ec2bb..50efa10d48450 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -292,6 +292,17 @@ config COMMON_CLK_S2MPS11
clock. These multi-function devices have two (S2MPS14) or three
(S2MPS11, S5M8767) fixed-rate oscillators, clocked at 32KHz each.
+config COMMON_CLK_TC9564
+ tristate "Toshiba TC9564 clock support"
+ depends on TC9564_PCI
select RESET_CONTROLLER
Thank you. The reset and clock drivers were previously separate
and the reset only became available if RESET_CONTROLLER was enabled.
Combining them means I need this. I will add it.
Why did you combine them ?
it would be a lot better if the reset were handled in
drivers/reset rather than in clock. There has already been some work to
move reset from clock back to reset. This often involve auxiliary drivers.
To be honest, I got a suggestion from someone to combine them, but
I said "no, I got feedback last year that separating them was
better." But then a second person told me that these are often
combined, so I took that as "two against one" and decided to
merge them.
The other reason is that four registers are used:
#define CLK_CTRL0_OFFSET 0x1004
#define RST_CTRL0_OFFSET 0x1008
#define CLK_CTRL1_OFFSET 0x100c
define RST_CTRL1_OFFSET 0x1010
They alternate between clock and reset. The previous separated
drivers specified the two offsets for each driver in the reg
property. But somehow these interleaved registers seemed a
little off, so I thought the combined driver cleaned that up
a little.
I don't have any strong preference one way or another. If you
think they're better separate, I don't mind separating them
again. The two drivers are extremely simple.
-Alex
