On Thu, Sep 24, 2026 at 05:30:02PM -0700, Mukesh R wrote: > On 9/18/26 03:48, Magnus Kulke wrote: > > On Thu, Sep 17, 2026 at 05:23:15PM -0700, Mukesh R wrote: > no, we need to backport deposit-pages also (it is already in the > internal 6.18) as not only it enhances the deposit, but also fixes > couple bugs, so best to keep this separate. the deposit patch does > address your comment: > > + HV_DEPOSIT_MAX is capped at 511, so a deposit range cannot cover > + * a 2MiB page, so deposited pages are of 4k granularity and cannot > + * be collapses into a 2MiB page, which would require an allocation > + * and can potentially fail. > > IOW, as soon as it's merged, above will not be true always.
understood, so we'll drop that comment. but we can keep the logic? (leaking the page should the make-valid call fail) best, magnus
