Re: [PATCH v8 4/4] kselftest: mm: remove check_huge_shmem()

[Sarthak Sharma]

On 9/25/26 12:41 AM, Yeoreum Yun wrote:
> check_huge_shmem() was required to distinguish shmem huge pages because
> /proc/self/smaps reports them using a dedicated “ShmemPmdMapped” entry,
> as opposed to “FilePmdMapped” for file-backed huge pages.
> 
> Now that /proc/self/smaps is no longer used to detect huge pages and
> /proc/kpageflags is used instead, it is sufficient to distinguish
> between file-backed and anonymous pages since the ShmemPmdMapped is also
> kind of file-backed.
> 
> Therefore, remove check_huge_shmem() and use check_huge_file() instead
> and cleanup khugepaged's check_huge operation in mem_ops.
> 
> Suggested-by: David Hildenbrand (Arm) <da...@kernel.org>
> Reviewed-by: Baolin Wang <baolin.w...@linux.alibaba.com>
> Acked-by: Zi Yan <z...@nvidia.com>
> Acked-by: Lorenzo Stoakes (ARM) <l...@kernel.org>
> Acked-by: David Hildenbrand (Arm) <da...@kernel.org>
> Signed-off-by: Yeoreum Yun <yeoreum....@arm.com>
> ---
Looks good to me, so:

Reviewed-by: Sarthak Sharma <sarthak.sha...@arm.com>