On Tue, Sep 29, 2026 at 06:41:55PM +0200, Francesco Valla wrote: > Add bindings for spi-virtio based on virtio-device, reflecting what > already exists for gpio-virtio and i2c-virtio. A node using the bindings
Existing code is not a reason to add more code. Existing bugs are not a reason to add more bugs. Please provide proper rationale why this suits DT. > is not used to instantiate the device, which is registered by the > transport (e.g.: virtio-mmio), but to define its properties and > establish dependencies with other nodes. > > Add the new bindings inside the MAINTAINERS file. > > Signed-off-by: Francesco Valla <[email protected]> > --- > .../devicetree/bindings/spi/spi-virtio.yaml | 53 > ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 54 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-virtio.yaml > b/Documentation/devicetree/bindings/spi/spi-virtio.yaml > new file mode 100644 > index 000000000000..5b8639dd2e1f > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-virtio.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/spi-virtio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Virtio SPI controller device > + > +maintainers: > + - Francesco Valla <[email protected]> > + > +allOf: > + - $ref: /schemas/spi/spi-controller.yaml# > + - $ref: /schemas/virtio/virtio-device.yaml# > + > +description: > + Virtio SPI controller device, see /schemas/virtio/virtio-device.yaml for > + more details. > + > +properties: > + $nodename: > + const: spi > + > + compatible: > + const: virtio,device2d >From where does the compatible come from? Best regards, Krzysztof
