Re: [PATCH v3 2/4] clk: toshiba: introduce a TC9564 SoC clock driver

[Alex Elder]

On 10/12/26 10:24 AM, Alex Elder wrote:

+static int tc9564_clk_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct tc9564_clocks *clocks;
+       struct clk *clk;
+
+       if (!dev_of_node(dev))
+               return dev_err_probe(dev, -EINVAL, "no devicetree node\n");
+
+       clk = devm_clk_get(dev, NULL);

This should be devm_clk_get_enabled().

(It still works this way, given it's an always-on fixed clock.)

                                        -Alex

+       if (IS_ERR(clk))
+               return dev_err_probe(dev, PTR_ERR(clk),
+                                    "failed to get input clock\n");
+
+       clocks = tc9564_clk_init(dev);
+       if (IS_ERR(clocks))
+               return dev_err_probe(dev, PTR_ERR(clocks),
+                                    "failed to initialize clocks\n");
+
+       /* Force all clocks to be initially disabled */
+       tc9564_clock_disable_all(clocks);
+
+       platform_set_drvdata(pdev, clocks);
+
+       return 0;
+}