This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writel'. Remove the macro.

Signed-off-by: H Hartley Sweeten <hswee...@visionengravers.com>
Cc: Ian Abbott <abbo...@mev.co.uk>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/staging/comedi/drivers/rtd520.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/rtd520.c 
b/drivers/staging/comedi/drivers/rtd520.c
index ff30253..781f081 100644
--- a/drivers/staging/comedi/drivers/rtd520.c
+++ b/drivers/staging/comedi/drivers/rtd520.c
@@ -407,10 +407,6 @@ struct rtdPrivate {
 /* Macros to access registers */
 
 /* Reset channel gain table read and write pointers */
-#define RtdClearCGT(dev) \
-       writel(0, devpriv->las0+LAS0_CGT_CLEAR)
-
-/* Reset channel gain table read and write pointers */
 #define RtdEnableCGT(dev, v) \
        writel((v > 0) ? 1 : 0, devpriv->las0+LAS0_CGT_ENABLE)
 
@@ -797,7 +793,8 @@ static void rtd_load_channelgain_list(struct comedi_device 
*dev,
 {
        if (n_chan > 1) {       /* setup channel gain table */
                int ii;
-               RtdClearCGT(dev);
+
+               writel(0, devpriv->las0 + LAS0_CGT_CLEAR);
                RtdEnableCGT(dev, 1);   /* enable table */
                for (ii = 0; ii < n_chan; ii++) {
                        RtdWriteCGTable(dev, rtdConvertChanGain(dev, list[ii],
@@ -2049,7 +2046,7 @@ static int rtd_attach(struct comedi_device *dev, struct 
comedi_devconfig *it)
        RtdInterruptClearMask(dev, ~0); /* and sets shadow */
        RtdInterruptClear(dev); /* clears bits set by mask */
        RtdInterruptOverrunClear(dev);
-       RtdClearCGT(dev);
+       writel(0, devpriv->las0 + LAS0_CGT_CLEAR);
        RtdAdcClearFifo(dev);
        RtdDacClearFifo(dev, 0);
        RtdDacClearFifo(dev, 1);
-- 
1.7.11

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to