CCing Andrew Morton, and Alexander Gordeev based on git log drivers/pps/pps.c Pardon me if i made wrong
On Sat, Jun 2, 2012 at 1:28 AM, Emil Goode <[email protected]> wrote: > We should return PTR_ERR if the call to the > device_create function fails. > Without this patch we instead return the value > from a successful call to cdev_add if the call > to device_create fails. > > Signed-off-by: Emil Goode <[email protected]> > --- > drivers/pps/pps.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c > index 98fbe62..e771487 100644 > --- a/drivers/pps/pps.c > +++ b/drivers/pps/pps.c > @@ -327,8 +327,10 @@ int pps_register_cdev(struct pps_device *pps) > } > pps->dev = device_create(pps_class, pps->info.dev, devt, pps, > "pps%d", pps->id); > - if (IS_ERR(pps->dev)) > + if (IS_ERR(pps->dev)) { > + err = PTR_ERR(pps->dev); > goto del_cdev; > + } > > pps->dev->release = pps_device_destruct; > > -- > 1.7.10 > Acked-By: Devendra Naga <[email protected]> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
