On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan <[email protected]> wrote:
> Converting the gpio driver of tps6586x to a platform > driver in place of registering the gpio through core > driver. > The motivation of the change is: > - This is inline with the mfd drivers implementation. > - This will move the related gpio support to gpio driver > folder where all gpio related drivers are available. > This will be easy the maintenance and enhancement is > anything done for gpio. > - The gpio functionality can be selected through config > variable. > > Signed-off-by: Laxman Dewangan <[email protected]> Overall this is very, very good and you're doing the right thing. > --- /dev/null > +++ b/drivers/gpio/gpio-tps6586x.c > +#include <linux/i2c.h> Why? Reviewed-by: Linus Walleij <[email protected]> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
