On 29/07/12 21:42, Mark Brown wrote:
On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote:

+       if (of_get_property(np, "stericsson,use-pinctrl", NULL))
+               msp->use_pinctrl = true;
+       else
+               msp->use_pinctrl = false;

I don't recall seeing any response to my query about this on the first
iteration.  Please don't just ignore review comments.

It wasn't intentional. I must have missed it before.

This doesn't seem particularly sane...  why is this conditional?

It's conditional because only MSP1 and MSP3 have pinctrl support.

Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to