On Mon, 30 Jul 2012 14:21:33 -0700 John Johansen <[email protected]> wrote:
> On 07/30/2012 09:58 AM, Kees Cook wrote: > > The core ptrace access checking routine already holds the task lock, > > so there is no need to use get_task_comm() which just tries to take the > > lock again. Drop its use and access current->comm directly. > > > > Reported-by: Fengguang Wu <[email protected]> > > Suggested-by: Oleg Nesterov <[email protected]> > > Cc: [email protected] > > Signed-off-by: Kees Cook <[email protected]> > yep, looks good > > Acked-by: John Johansen <[email protected]> Code looks correct but having a weird cornercase direct reference is asking for an accident later. For maintainability I'd rather see that as __get_task_comm() or get_task_commu_unlocked() which does the job, deals with all the edge cases and contains a WARN_ON check on the lock. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
